Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Update github actions to v4 #36

Merged
merged 4 commits into from
Apr 17, 2024
Merged

.github: Update github actions to v4 #36

merged 4 commits into from
Apr 17, 2024

Conversation

norihiro
Copy link
Owner

@norihiro norihiro commented Apr 17, 2024

Description

Old versions caused deprecation warnings as below.

Node.js 16 actions are deprecated

Since the new action actions/upload-artifact@v4 does not merge files when uploading with the same name, the artifact names are differentiated for each job and matrix.

How Has This Been Tested?

General checklist

  • The commit is reviewed by yourself.
  • The code is tested.
  • Document is up to date or not necessary to be changed.
  • The commit is compatible with repository's license.

Old versions caused deprecation warnings as below.
> Node.js 16 actions are deprecated

Since the new action actions/upload-artifact@v4 does not merge files
when uploading with the same name, the artifact names are differentiated
for each job and matrix.
Previously it pointed to v1, which caused deprecation warnings as below.
> Node.js 16 actions are deprecated.
The notarytool should be skipped if the necessary variables are not set.
Also fixed the deprecated `set-output` command in the workflow file.
The versions 36 and 37 were no longer supported.
This commit also adds a script to generate the release-version specific
files so that it's easier to maintain the target release versions.
@norihiro norihiro merged commit a335af8 into main Apr 17, 2024
8 checks passed
@norihiro norihiro deleted the gh-actions-202404 branch April 17, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant